search

rubblelabs / tx

Tool for executing transactions on the Ripple network
19 stars 8 forks source link

Add trust command #12

Closed singpolyma closed 10 years ago

singpolyma commented 10 years ago

Allows user to set trust to another address.

Setting trust with an amount of 0 seems to be failing... can't figure out why. All others seem to work.

donovanhide commented 10 years ago

What did the JSON and binary look like for the 0 case? Might be something to do with the Value encoding. Would be good to get a testcase. Might be worth comparing the output from rippled sign for the same JSON input.

lukecyca commented 10 years ago

I found that we had an encoding bug that only affected non-native zero values. Fixed in: https://github.com/rubblelabs/ripple/commit/e370133ce1260009f423c9e07b03f56b39aaa2e1

This branch now works perfectly for me. I can set and unset trust lines, with or without quality, etc.

Awesome!

donovanhide commented 10 years ago

Ace! Good work!