rubegartor / ReelSteady-Joiner

ReelSteady Joiner merge multiple GoPro separate video files into one without losing the gyro data
MIT License
93 stars 6 forks source link

Static ffmpeg build doesn't work #33

Closed porfel closed 1 year ago

porfel commented 1 year ago
NonError: {
  error: Error: Command failed: "/Applications/ReelSteady Joiner.app/Contents/Resources/app.asar.unpacked/node_modules/ffmpeg-static/ffmpeg" -i "/Volumes/SD_Card/DCIM/100GOPRO/GX020005.MP4"
  /bin/sh: /Applications/ReelSteady Joiner.app/Contents/Resources/app.asar.unpacked/node_modules/ffmpeg-static/ffmpeg: Bad CPU type in executable

      at ChildProcess.exithandler (node:child_process:407:12)
      at ChildProcess.emit (node:events:527:28)
      at maybeClose (node:internal/child_process:1092:16)
      at Socket.<anonymous> (node:internal/child_process:451:11)
      at Socket.emit (node:events:527:28)
      at Pipe.<anonymous> (node:net:709:12) {
    code: 126,
    killed: false,
    signal: null,
    cmd: '"/Applications/ReelSteady Joiner.app/Contents/Resources/app.asar.unpacked/node_modules/ffmpeg-static/ffmpeg" -i "/Volumes/SD_Card/DCIM/100GOPRO/GX020005.MP4"'
  },
  stderr: '/bin/sh: /Applications/ReelSteady Joiner.app/Contents/Resources/app.asar.unpacked/node_modules/ffmpeg-static/ffmpeg: Bad CPU type in executable\n'
}
    at module.exports (/Applications/ReelSteady Joiner.app/Contents/Resources/app.asar/node_modules/ensure-error/index.js:14:10)
    at handleError (/Applications/ReelSteady Joiner.app/Contents/Resources/app.asar/node_modules/electron-unhandled/index.js:50:10)
    at process.<anonymous> (/Applications/ReelSteady Joiner.app/Contents/Resources/app.asar/node_modules/electron-unhandled/index.js:130:4)
    at process.emit (node:events:527:28)
    at emit (node:internal/process/promises:140:20)
    at processPromiseRejections (node:internal/process/promises:269:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:97:32)

reelsteady-joiner 1.3.0-beta Electron 20.0.2 darwin 21.6.0 Locale: ru

If i replace ffmpeg binary to link to system ffmpeg (from brew) - all works correctly.

rubegartor commented 1 year ago

Are you trying to run ReelSteady Joiner from a processor with x64 or arm64 architecture? You can also specify the exact version of MacOS you are using e.g (Monterey 12.4) Any information you can provide is welcome

porfel commented 1 year ago

I use x86_64 mac with intel core i9. I guess this happens because asserts build on mac with Apple M1, and npm fetchs ffmpeg-static for this architecture. If i build from sources - all is ok, working version of ffmpeg downloaded in modules.

2022-08-18_19-37-00

porfel commented 1 year ago

Yes, it is: 2022-08-18_20-02-46

rubegartor commented 1 year ago

The new binaries have already been updated in version 1.3.0-beta, if you could test them and confirm their correct operation it would be of great help to me.

porfel commented 1 year ago

Now it is not installed yet. In install dialog all is ok, but after install no app present and no contents for realsteady joiner in /Applications... Steps to reproduce:

rubegartor commented 1 year ago

I've reuploaded the macOS builds where this issue should have been resolved as well. Thanks for your help.

porfel commented 1 year ago

Now all works perfect, includes ffmpeg for x86-64. Thank you very much for your work!