rubegartor / ReelSteady-Joiner

ReelSteady Joiner merge multiple GoPro separate video files into one without losing the gyro data
MIT License
100 stars 6 forks source link

[BUG] After merger of GoPro MAX files, sometimes a part of the video becomes jumpy #73

Closed ydutertre closed 6 months ago

ydutertre commented 8 months ago

Describe the bug After merger of GoPro MAX files, sometimes a part of the video becomes jumpy. Each individual GoPro MAX file is fine, playback is very smooth. But after merging via Reelsteady, sometimes (not always) part of the video (usually the part corresponding to the last clip being merged) will become jumpy, with the FOV bouncing abruptly every few seconds.

To Reproduce Steps to reproduce the behavior:

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

GoPro camera and files information (If applicable)

Additional context Add any other context about the problem here.

[IMPORTANT] Video Files

https://drive.google.com/drive/folders/1PGT0yrohWRx6xLxRgya_uBG_jFOt_20d?usp=sharing (files being uploaded, will be ready a couple of hours after posting) After joining these files you can look at around 1:15:30 (or any other time after that or within 9 minutes 28 seconds of the end) to see the footage jumps every few seconds. This seems to correspond to the last clip joined (the clip itself doesn't have this jumpiness).

**[IMPORTANT]

GS010094_Jan 19, 2024 6-57 PM.log

DennisOtto-dev commented 8 months ago

is there any quickfix on how to avoid that?

rubegartor commented 8 months ago

I'm reviewing it, during the next few days I hope to be able to tell you something more.

DennisOtto-dev commented 8 months ago

I experienced this issue starting with the second clip. the first clip (8:02min) long is fine and right when the second clip begins there is a strong shaking in the video until the end of all clips.

rubegartor commented 8 months ago

Unfortunately no, I have not yet been able to identify the problem. If you could share your clips it would be a big help in trying to find the problem.

DennisOtto-dev commented 8 months ago

sorry, I would love to help, but these are private family vacation recordings

ydutertre commented 8 months ago

Thanks for looking at this! Please let me know when it would be OK for me to delete the clips from cloud storage, as they are eating up my quota :-)

No urgency on my part, for now I'm manually converting the clips to MP4 then joining in DaVinci Resolve before injecting back 360 metadata, seems to work fine as a workaround

rubegartor commented 8 months ago

You can delete the clips without any problem!

rubegartor commented 8 months ago

I'm having problems with your files, I'm only able to load up to minute 21:44 in GoPro Player, is this same problem happening to you too?

ydutertre commented 8 months ago

Weird, I don't have that issue. I can load up just fine to 24 minutes something... (Full length of each sub recording)

On Sat, Jan 27, 2024, 05:07 Rubén @.***> wrote:

I'm having problems with your files, I'm only able to load up to minute 21:44 in GoPro Player, is this same problem happening to you too?

— Reply to this email directly, view it on GitHub https://github.com/rubegartor/ReelSteady-Joiner/issues/73#issuecomment-1912625835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYF42EFRZLKFKGIBYEKPBJ3YQQEGPAVCNFSM6AAAAABCBWVALKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGYZDKOBTGU . You are receiving this because you authored the thread. Message ID: @.***>

rubegartor commented 8 months ago

@ydutertre I think I have it, throughout these days I hope to be able to share a pre-release so you can carry out your own tests

DennisOtto-dev commented 8 months ago

I am also excited! Looking forward to the pre-release

ydutertre commented 8 months ago

Awesome! Looking forward to it!

On Thu, Feb 1, 2024, 05:41 Rubén @.***> wrote:

@DennisOtto-dev https://github.com/DennisOtto-dev I think I have it, throughout these days I hope to be able to share a pre-release so you can carry out your own tests

— Reply to this email directly, view it on GitHub https://github.com/rubegartor/ReelSteady-Joiner/issues/73#issuecomment-1919920478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYF42EGFOWTQ4ZVUXQP4U3LYRKT6NAVCNFSM6AAAAABCBWVALKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZHEZDANBXHA . You are receiving this because you authored the thread.Message ID: @.***>

rubegartor commented 8 months ago

I have just released a pre-release with new changes that should solve this problem, there is a new option: Processing type, I recommend using it with the value: MP4Merge, carry out your own tests, I hope this will solve the problems.

ReelSteady Joiner 1.3.3-beta

It would be helpful to know the test results!

mglakner commented 8 months ago

I had the same issue, just tried the beta 1.3.3 release and can confirm the jumpiness is gone. Thank you! on Macbook Pro M1 Pro.

Tried on an intel mac mini and got an "Unhandled Error"

Error: spawn /Applications/ReelSteady Joiner.app/Contents/app/bin/mac/mp4merge EACCES at ChildProcess._handle.onexit (node:internal/child_process:284:19) at onErrorNT (node:internal/child_process:477:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

rubegartor commented 8 months ago

I had the same issue, just tried the beta 1.3.3 release and can confirm the jumpiness is gone. Thank you! on Macbook Pro M1 Pro.

Tried on an intel mac mini and got an "Unhandled Error"

Error: spawn /Applications/ReelSteady Joiner.app/Contents/app/bin/mac/mp4merge EACCES at ChildProcess._handle.onexit (node:internal/child_process:284:19) at onErrorNT (node:internal/child_process:477:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

I have updated the installers and the problem should disappear. If you can confirm it, I would appreciate it since I do not have a Mac with a x64 processor.

mglakner commented 8 months ago

I had the same issue, just tried the beta 1.3.3 release and can confirm the jumpiness is gone. Thank you! on Macbook Pro M1 Pro. Tried on an intel mac mini and got an "Unhandled Error" Error: spawn /Applications/ReelSteady Joiner.app/Contents/app/bin/mac/mp4merge EACCES at ChildProcess._handle.onexit (node:internal/child_process:284:19) at onErrorNT (node:internal/child_process:477:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

I have updated the installers and the problem should disappear. If you can confirm it, I would appreciate it since I do not have a Mac with a x64 processor.

Can confirm, 1.3.3 Beta works on x64 and Apple Silicon.

DennisOtto-dev commented 8 months ago

I still have the same problem with 1.3.3 beta. It's better, but I still have shaking in my video clip. I have merged six 360 videos from the GoPro MAX together (total length: 40min) and experience shaking throughout the video after the second clip begins. I use the windows version of the software :)

ydutertre commented 7 months ago

Apologies for the late reply, I was waiting to have some long video to test it out. This seems to have fixed the issue for me! I just merged 7*24 minute long GoPro MAX clips, and I don't see any issue. Note however that I am using the Beta firmware of GoPro Max that allows longer clips, so maybe related?

@DennisOtto-dev you are absolutely sure you were running 1.3.3 beta and had restarted the PC first (I needed to do that)

rubegartor commented 6 months ago

ReelSteady Joiner v1.3.3 now available