search

rubellyte / starcheat

Starbound player save editor and Python library
http://starcheat.org/
MIT License
10 stars 5 forks source link

Reading player files is incredibly slow #23

Closed DaftLad closed 8 years ago

DaftLad commented 8 years ago

It takes about 4 to 8 minutes for Starcheat to finish reading player files. I only have two characters, and I've tried to clear their inventories and getting rid of any custom items they have on them, along with removing all mods I have to see if it made it read any faster. No dice. I've linked others this version of Starcheat and they have no issues with it. What's going on here?

rubellyte commented 8 years ago

Can you provide a log file for me? Also a list of any mods you have installed would be helpful. That's very unusual for loading time, I have extremely large player files and it only takes me 30 seconds or so to load.

DaftLad commented 8 years ago

starcheat.txt This is without any mods. The mods I used before was Extra Zoom Levels, Manipulated UI, Infinite Reach, Spawnable Item Pack and Wardrobe.

rubellyte commented 8 years ago

Wow, shit. There's nothing unusual happening in there, so I really have no idea what's going on here.

DaftLad commented 8 years ago

It's strange that this is happening in the first place, since I had no issues with the older version of Starcheat, the one for Glad Giraffe. Though, wizzomafizzo mentioned something about "this implementation and py-starbound" on another issue. https://github.com/wizzomafizzo/starcheat/issues/282 I'm no coder or programmer, but maybe that's got something to do with it? Just a wild guess.

kurisubrooks commented 8 years ago

Hi, could we please have your .player files for testing? We'd like to find out the cause of this.

DaftLad commented 8 years ago

Player Files.zip Here you go.

rubellyte commented 8 years ago

Alright so I loaded up your player files and can confirm it takes a stupidly long time. It looks like the issue is that your player file contains approximately 111,000 (!) lines of blueprints. It looks like the wait time is from Starcheat loading the files into memory and converting them to JSON for editing, and it has to convert said 111,000 lines, which takes a while. I unfortunately don't think I can do anything about this.

wizzomafizzo commented 8 years ago

is there a loading bar or some kind of notification during this load? i doubt it can be sped up but i've found showing the user that something is happening goes a long way to make things seem faster

kurisubrooks commented 8 years ago

There's a loading bar when loading the player files image

There's also one when loading the .player file into the program image