search

rubengarciam / wayne

Comic Book Manager & Reader
https://pinwi.co/wayne
7 stars 0 forks source link

Navigation bars is missing accent colors #39

Closed rubengarciam closed 4 years ago

rubengarciam commented 4 years ago

Describe the bug

There seems to be a bug in the latest Xcode12 beta-3 whereby some views might lose the configured accent color.

It also seems the sidebar items UI is broken for dark mode.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Library
  2. Minize sidebar
  3. Open any comic
  4. Open Goodreads search sheet
  5. See error: accent color is lost, both for the sheet and sidebar title

Screenshots

IMG_0207 IMG_0208 IMG_0209 IMG_0210

rubengarciam commented 4 years ago

Uppon further investigation. it seems that having a .sheet or .fullScreenCover in child views screw the main navigation view’s accent color.

I created some dummy projects but haven’t been able to replicate this issue. Hence, I must be doing something in the view’s transition that breaks the accent color.

rubengarciam commented 4 years ago

Fixed. The Edit Comic view backgrounds modifier were screwing with the accent colors.

I have modified them and fixed a couple of other UI glitches along the way