search

rubengc / cmb2-field-ajax-search

CMB2 field type to attach posts, users or terms.
33 stars 24 forks source link

Update cmb2-field-ajax-search.php #6

Closed Daneel87 closed 5 years ago

Daneel87 commented 6 years ago

Enqueue scripts for frontend use

rubengc commented 6 years ago

Hi @Daneel87

Thank you so much for your commit

I need to investigate more deep the CMB2 script enqueuing mechanism because they have a way to just enqueue those scripts just when field has been rendered

At this moment with your commit, scripts are enqueued to the whole frontend (included if the field never gets rendered at this part) so it needs the improvement I mention

rubengc commented 5 years ago

Hi @Daneel87

I will close this PR since I need to investigate a more efficient way to enqueue scripts just when needed

Thanks for your contribution!