search

rubenlagus / TelegramBots

Java library to create bots using Telegram Bots API
https://telegram.me/JavaBotsApi
MIT License
4.77k stars 1.22k forks source link

Apache HTTP Components could shaded #100

Closed d2a-raudenaerde closed 6 years ago

d2a-raudenaerde commented 8 years ago

Currently it is a pain to include other libs (for example jenkins-client) in an project that also depends on telegrambots, because HttpComponents conflict easily.

Please shade/repackage the Apache Http client (see mvn shade plugin)

rubenlagus commented 8 years ago

mmm... I've never faced such an issue and therefore I'm not familiar with shade plugin. If you are, feel free to open a pull request with it.

d2a-raudenaerde commented 8 years ago

If I can fine time, I'll try to do this. btw: more info can be found here: http://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html and here: http://thinkoutofthenet.com/index.php/2014/01/16/solution-to-jar-dependency-conflict-problem-with-maven/

d2a-raudenaerde commented 8 years ago

See the pull-request: #103

d2a-raudenaerde commented 8 years ago

Oh I see I needed to make a pull-request on DEV.. Thanks for fixing this!

rubenlagus commented 8 years ago

I took away this changes from lates version, it was messing up the dependencies. I'll try to have a deeper look when I have more time, sorry.