search

rubenlagus / TelegramBots

Java library to create bots using Telegram Bots API
https://telegram.me/JavaBotsApi
MIT License
4.54k stars 1.14k forks source link

Refactoring: Enhancing code maintainability by reducing code smells. #1336

Open Yukta026 opened 3 months ago

Yukta026 commented 3 months ago

By this pull request, I am reaching out to submit my refactoring improvements for your consideration. These changes aim to improve readability, maintainability, and performance while aligning with best practices and the project's objectives.

Chase22 commented 3 months ago

Something is not right with the git commits in this PR. It's trying to merge a lot more commits than it should. Please make sure you branch is up to date and based on the devbranch.

I'll be looking through these but please tell your professor that open-source developers aren't outsourced teachers and that we have to invest quite significant time into the reviews.

Yukta026 commented 3 months ago

Thank you for taking the time to review my pull request and providing feedback. To address the issue regarding the git commits, I've conducted a thorough analysis of the changes made. In total, there are 11 commits originating from my assignment2 branch, affecting a total of 21 files.

Furthermore, I've ensured that my branch is up to date and based on the dev branch by incorporating the latest changes from the dev branch into my own. This includes resolving any merge conflicts that arose, such as the one encountered in the Story.java file.

I greatly appreciate the time and effort you've dedicated to reviewing my contributions to this repository. My ultimate goal is to make meaningful contributions, and I'm committed to ensuring the quality and integrity of my work. Please feel free to take as much time as needed for further review.

Yukta026 commented 3 months ago

I want to help the developer of this library so I did my own code review. See the github code comments. Also, why do you leave explanations to your refactor in the code comments? Keep in mind that you request to merge your code (including comments) into the upstream repository. Which means people who would like to inspect the code in the future and create their own pull requests, will have to read through your changelog in the code, when there's VCS (git) for this

Thank you for your insightful feedback on the code review. I have thoroughly reviewed all the suggested changes and made every effort to incorporate them. If you believe any additional modifications are necessary, please don't hesitate to inform me.