search

rubenlagus / TelegramBots

Java library to create bots using Telegram Bots API
https://telegram.me/JavaBotsApi
MIT License
4.68k stars 1.18k forks source link

Location and SendLocation #184

Closed The28AWG closed 7 years ago

The28AWG commented 7 years ago

Hello! Need equal type latitude and longitude in class Location and SendLocation https://github.com/rubenlagus/TelegramBots/blob/master/telegrambots-meta/src/main/java/org/telegram/telegrambots/api/methods/send/SendLocation.java#L35 https://github.com/rubenlagus/TelegramBots/blob/master/telegrambots-meta/src/main/java/org/telegram/telegrambots/api/objects/Location.java#L19

Optional need constructor new SendLocation(Location), or need method setLocation(Location). Hmmm... its not optimal idea.

rubenlagus commented 7 years ago

If Location and SendLocation are not the same, not the best option to add them...

The28AWG commented 7 years ago

Need one type! It is important! Double not equals Float!

rubenlagus commented 7 years ago

I'll change the Location ones to Float to match the correct type in docs for next release.