rubensayshi / gw2spidy

GW2Spidy - Guild Wars 2 Tradingpost Graphs
http://www.gw2spidy.com
231 stars 86 forks source link

Tooltip not loading on https #161

Closed jb-lopez closed 9 years ago

jb-lopez commented 9 years ago

Tested on Firefox and Chrome. The console in Firefox reads as follows:

Blocked loading mixed active content "http://www.gw2spidy.com/api/v0.9/json/item-tooltip/11230&callback=WP_OnTooltipLoaded?_=1425411223331"

The offending code appears to be at /webroot/assets/js/tooltip.js:307

var e = "http://" + window.location.host;
rubensayshi commented 9 years ago

the problem seems to be that the URL it's trying to load is "http://www.gw2spidy.com/api/v0.9/json/item-tooltip/11230&callback=WP_OnTooltipLoaded?_=1425411223331" and the & before the callback= should be an ?

which happens here; https://github.com/rubensayshi/gw2spidy/blob/master/webroot/assets/js/tooltip.js#L103

eureka I figured it out, you visiting gw2spidy using HTTPS, cloudflare seems to have silently enabled that without notifying me and I never tested visiting the site on HTTPS

rubensayshi commented 9 years ago

fixed it