search

rubensayshi / gw2spidy

GW2Spidy - Guild Wars 2 Tradingpost Graphs
http://www.gw2spidy.com
231 stars 86 forks source link

Added Sortable Margin Field #31

Closed sstorrow closed 12 years ago

sstorrow commented 12 years ago

The margin is calculated from (min_sale_price * 0.85) - max_buy_price. Also made it sortable on the item_list.

First time using github so let me know if you need any more info.

rubensayshi commented 12 years ago

Thanks for the awesome new feature!

Merged and deployed it right away :-)

sstorrow commented 12 years ago

No problems, it doesn't seem to have gone through to the '/search' page though so maybe I forgot a change in index.php.

On 21 September 2012 14:04, Ruben de Vries notifications@github.com wrote:

Thanks for the awesome new feature!

Merged and deployed it right away :-)

— Reply to this email directly or view it on GitHubhttps://github.com/rubensayshi/gw2spidy/pull/31#issuecomment-8763825.

rubensayshi commented 12 years ago

Nah, that's the varnish cache on the server I think ;)

On Fri, Sep 21, 2012 at 3:28 PM, sstorrow notifications@github.com wrote:

No problems, it doesn't seem to have gone through to the '/search' page though so maybe I forgot a change in index.php.

On 21 September 2012 14:04, Ruben de Vries notifications@github.com wrote:

Thanks for the awesome new feature!

Merged and deployed it right away :-)

— Reply to this email directly or view it on GitHub< https://github.com/rubensayshi/gw2spidy/pull/31#issuecomment-8763825>.

— Reply to this email directly or view it on GitHubhttps://github.com/rubensayshi/gw2spidy/pull/31#issuecomment-8764559.

sstorrow commented 12 years ago

Ah yes it seems to have propagated through to search too now.

On 21 September 2012 14:29, Ruben de Vries notifications@github.com wrote:

Nah, that's the varnish cache on the server I think ;)

On Fri, Sep 21, 2012 at 3:28 PM, sstorrow notifications@github.com wrote:

No problems, it doesn't seem to have gone through to the '/search' page though so maybe I forgot a change in index.php.

On 21 September 2012 14:04, Ruben de Vries notifications@github.com wrote:

Thanks for the awesome new feature!

Merged and deployed it right away :-)

— Reply to this email directly or view it on GitHub< https://github.com/rubensayshi/gw2spidy/pull/31#issuecomment-8763825>.

— Reply to this email directly or view it on GitHub< https://github.com/rubensayshi/gw2spidy/pull/31#issuecomment-8764559>.

— Reply to this email directly or view it on GitHubhttps://github.com/rubensayshi/gw2spidy/pull/31#issuecomment-8764613.

rubensayshi commented 12 years ago

fixed #8