search

rubensayshi / gw2spidy

GW2Spidy - Guild Wars 2 Tradingpost Graphs
http://www.gw2spidy.com
231 stars 86 forks source link

Margin Percentage #35

Open sstorrow opened 12 years ago

sstorrow commented 12 years ago

After chatting to some economic bods, they've suggested that the margin column should be displayed as a percentage of the sell price. I'll have a look at submit a pull request later.

sstorrow commented 12 years ago

Attempted fix in #37 still needs some work though.

rubensayshi commented 12 years ago

need to remove the margin part and start using the /profit page as described below

the top 500 items by margin have insane margins because they're based on thrash listings however ... not sure how to deal with that ...

I already made something like this before (see /profit) but haven't released it yet exactly because of this problem ... without proper filters I think this is pointless ...

Maybe we're best off continueing based on my /profit page and add some proper filtering to it, trying to work this into the normal item list might add a lot of clutter to the page (and slow it down).

ps. mysql ignores division by 0 errors lol ... so should have gone for postgresql :P