rubensayshi / gw2spidy

GW2Spidy - Guild Wars 2 Tradingpost Graphs
http://www.gw2spidy.com
231 stars 86 forks source link

Incorrect recipe price calculation #86

Closed mercutiodesign closed 11 years ago

mercutiodesign commented 11 years ago

If you have a recipe for item A that yields multiple items and another recipe that only uses one of A than the price is calculated incorrectly.

For example: The Bowl of Tasty Wurm Stew requires one Bowl of Herbed Meat Stew. The price displayed in the Craft Column of the recipe is for 3 Herbed Meat Stews and therefore it advises to buy from TP even though crafting is much cheaper.

Bowl s of Herbed Meat Stock

Bowl s of Tasty Wurm Stew I GW2Spidy

aruggles commented 11 years ago

I don't think the price is calculated incorrectly. That is the price you'd need to pay to craft a bowl of meat stock regardless if you only need one. Since there isn't a way to craft only one.

Maybe if there was an option to sell back the unused amount, or the price to craft/buy x amount of the final product.

mercutiodesign commented 11 years ago

I agree that there is a problem with calculating the price in this case but I do think that the recommendation to buy from the TP is very bad since you can actually craft the Herbed Meat Stock for a profit as long as you craft it in batches of 3.

I would argue that it should display the correct crafted price (that is price for 3 items divided by 3) and maybe show a red triangle warning you that you that you can only craft in batches of 3.

Another alternative would be to automatically multiply the entire recipe by three if you click on "Craft" (with a notice explaining why that is necessary) but keep the current view if you have "TP" selected.

Edit: Also the price is incorrect, because it says that crafting 1 Bowl of Herbed Meat Stock costs 2s80c when in reality it only costs a third of that.