search

rubensworks / ScholarMarkdown

A framework for writing markdown-based scholarly articles.
MIT License
42 stars 8 forks source link

Drop old Linux support in favor of M1 Apple Silicon Macs #30

Closed smessie closed 2 years ago

smessie commented 2 years ago

Follow-up of #29 to really fix it by dropping old Linux support and fully move to mini_racer instead of therubyracer.

rubensworks commented 2 years ago

@RubenVerborgh Can you confirm that this works on your end as well?

RubenVerborgh commented 2 years ago

I confirm bundle install works when run in the root of this git branch.

(Did have to first uninstall Python 3.10 though, because it wants at most Python 3.9. But ok.)

RubenVerborgh commented 2 years ago

Needs Gemfile update

index c3edc94..c2089a7 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -77,7 +77,6 @@ GEM
       kramdown (~> 2.0)
       sskatex (>= 0.9.37)
     latex-decode (0.3.2)
-    libv8 (3.16.14.19)
     libv8-node (16.10.0.0)
     libv8-node (16.10.0.0-x86_64-darwin-19)
     mini_portile2 (2.6.1)
@@ -106,15 +105,11 @@ GEM
     rake (13.0.6)
     rchardet (1.8.0)
     rdoc (6.3.2)
-    ref (2.0.0)
     rexml (3.2.5)
     ruby2_keywords (0.0.5)
     semver2 (3.4.2)
     sskatex (0.9.39)
       execjs (~> 2.7)
-    therubyracer (0.12.3)
-      libv8 (~> 3.16.14.15)
-      ref
     thread_safe (0.3.6)

 PLATFORMS
@@ -137,7 +132,6 @@ DEPENDENCIES
   mini_racer
   puma
   sskatex
-  therubyracer
smessie commented 2 years ago

Needs Gemfile update

Yeah, I had to revert those changes as he does this upon release (see resolved review comment above), so should be fine once merged and released.

rubensworks commented 2 years ago

Thanks @smessie! Released as 3.0.0.

RubenVerborgh commented 2 years ago

Confirmed working for https://github.com/SolidLabResearch/WhatsInAPod/commit/15e7eca14c478e97f0d3d0ef8e9d7c11240012ef