rubensworks / fetch-sparql-endpoint.js

A simple, lightweight module to send queries to SPARQL endpoints and retrieve their results in a streaming fashion.
MIT License
22 stars 13 forks source link

`fetch()`'s `input` argument is not optional #64

Closed Peeja closed 1 year ago

Peeja commented 1 year ago

It's not optional in the browser DOM signature which this is emulating, and it's not clear what the behavior of a fetch() should be if it were given undefined. Type-wise, making this optional requires any client code providing a fetch() function to handle the undefined value, even though it's nonsensical.

See also https://github.com/comunica/comunica/pull/1233: Comunica's fetch() implementations don't accept undefined, but it wasn't breaking because "strictFunctionTypes": false was ignoring the errors.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5601690892


Totals Coverage Status
Change from base Build 5387797736: 0.0%
Covered Lines: 87
Relevant Lines: 88

💛 - Coveralls
rubensworks commented 1 year ago

Thanks! Released as 4.0.0.