rubensworks / rdf-test-suite.js

Executes the RDF and SPARQL test suites.
MIT License
9 stars 6 forks source link

feat: add Github pages compatibility #91

Closed jitsedesmet closed 1 year ago

jitsedesmet commented 1 year ago

This PR aims to provide GitHub pages compatibility as discussed in https://github.com/comunica/sparqlee/pull/163 .

jitsedesmet commented 1 year ago

Currently, 3 tests seem to be failing:

 FAIL  test/e2e-test.ts (47.38 s)
  ● e2e tests on the test suite runner › parsing › it should correctly run [http://w3c.github.io/rdf-tests/trig/manifest.ttl]

    expect(received).toEqual(expected) // deep equality

    Expected: true
    Received: false

      87 |
      88 |         // All tests should either be ok or skipped
    > 89 |         expect(result.every(r => r.ok || r.skipped)).toEqual(true);
         |                                                      ^
      90 |       }, 190_000);
      91 |     }
      92 |   });

      at test/e2e-test.ts:89:54
      at fulfilled (test/e2e-test.ts:5:58)

  ● e2e tests on the test suite runner › parsing › it should correctly run [https://w3c.github.io/json-ld-streaming/tests/stream-toRdf-manifest.jsonld]

    expect(jest.fn()).not.toHaveBeenCalled()

    Expected number of calls: 0
    Received number of calls: 18

    1: "TypeError: fetch failed"
    2: "TypeError: fetch failed"
    3: "TypeError: fetch failed"

      70 |         expect(console.log).not.toHaveBeenCalled();
      71 |         expect(console.warn).not.toHaveBeenCalled();
    > 72 |         expect(console.error).not.toHaveBeenCalled();
         |                                   ^
      73 |         expect(result.length).toBeGreaterThan(0);
      74 |
      75 |         let skipped = 0;

      at test/e2e-test.ts:72:35
      at fulfilled (test/e2e-test.ts:5:58)

  ● e2e tests on the test suite runner › query › should run correctly on [http://www.w3.org/TR/sparql11-query/]

    expect(jest.fn()).toHaveBeenCalledTimes(expected)

    Expected number of calls: 6
    Received number of calls: 164

      114 |         expect(console.warn).not.toHaveBeenCalled();
      115 |         // One error for each of the tsv cases
    > 116 |         expect(console.error).toHaveBeenCalledTimes(6);
          |                               ^
      117 |
      118 |         expect(result.length).toBeGreaterThan(0)
      119 |

      at test/e2e-test.ts:116:31
      at fulfilled (test/e2e-test.ts:5:58)
jitsedesmet commented 1 year ago

Strangely, I changed nothing and now all tests pass?

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4724063210


Totals Coverage Status
Change from base Build 4563517478: 0.0%
Covered Lines: 772
Relevant Lines: 772

💛 - Coveralls
rubensworks commented 1 year ago

Thanks! Released as 1.23.1