rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 129 forks source link

Added support for handling multiple filters that seemed to be missing. #136

Open Carl-David opened 8 years ago

Carl-David commented 8 years ago

I noticed that there was support for having an array of translation attributes for HTML tags, but not inside angular filters. So instead of using the initial single attribute in mkAttrRegex (that was previously hardcoded btw), it now uses the attributes array that can be specified as an option to the Extractor. This change is useful when having two different angular filters that both should be picked up and extracted for translation.

danjarvis commented 7 years ago

👍

This is a great patch. Any chance it will be getting merged?