Closed murataydos closed 8 years ago
@rubenv A reminder of this pull request. It would be great if you can review this. Thanks.
I'm not sure I want to go down the road of building all possible post-processing into angular-gettext.
As an alternative, have you considered extracting strings from the compiled templates?
If that is not an option, I'd recommend a separate build step which processes the .pot
file, rather than adding more features to angular-gettext.
Development environment doesn't use compiled templates, so extracting strings from compiled templates wouldn't help much since we want to be able to test it in development environment too.
Adding another build step makes sense.
Thanks.
Should be relatively easy with https://github.com/rubenv/pofile, which is what angular-gettext uses internally.
@rubenv Can you review this PR please?
I added an option to
compile
so that it can remove whitespaces frommsgid
.Why do we need this? When we compile angular templates, all the whitespaces are also removed. So some of the strings don't match with the ones in translation dictionary.
Example angular template:
translation dictionary:
compiled template:
translation dictionary if
removeWhiteSpaces
option is set totrue
: