search

rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 129 forks source link

Broken for ES5 since 2.3.6 #173

Open Jesus89 opened 7 years ago

Jesus89 commented 7 years ago

Pull request #171 adds ES6 code, crashing for ES5 projects.

rubenv commented 7 years ago

@Jesus89 This is angular-gettext-tools, which you normally only call from Node.

What do you mean with ES5 projects?

Jesus89 commented 7 years ago

Hi @rubenv

I am using angular-gettext-tools in a NW.js project without babel. All is written in EcmaScript5. When I updated the dependencies, the following error appeared:

".../node_modules/typescript-eslint-parser/lib/ast-converter.js:41
module.exports = (ast, extra) => {
                              ^^
Unexpected token =>"

So I checked that from 2.3.5 to 2.3.6, two major jumps where added in the 'typescript-eslint-parser' package, than includes EcmaScript6 code. I didn't expect that in a bugfix release, so I changed from "~2.3.3" to "2.3.5".

rubenv commented 7 years ago

I see, didn't expect them to make that much of a jump either.

Either way: I'm pretty sure NW.js supports short function syntax, have you tried upgrading your runtime?

Jesus89 commented 7 years ago

I have pending to update NW.js to the latest version in my project. I will check this issue again when all is up to date.