search

rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 130 forks source link

Cannot extract "constructor" #188

Closed AlexSchuetz closed 6 years ago

AlexSchuetz commented 6 years ago

The text "constructor" doesn't get extracted.

Here is an example. The following HTML will have no extracted text: `

constructor

`

This is case sensitive, because this works as expected: `

Constructor

`

Other possible keywords don't seem to produce this issue. I tested "if" and "function".

rubenv commented 6 years ago

There's nothing in the code that handles constructor specifically, so that's very strange.

Could you make a pull request with a failing unit test?

rubenv commented 6 years ago

Whew, that was interesting!

constructor was clashing with a JS built-in, thus getting ommitted. Anyway, fixed pushed and released to NPM as v2.3.13.

Thanks a lot!

AlexSchuetz commented 6 years ago

Wow. That was fast. Thank you.