search

rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 130 forks source link

Typescript 3 support #192

Closed ngehlert closed 5 years ago

ngehlert commented 5 years ago

I know you are currently looking for a new maintainer, so just checking if you maybe are still in touch here.

It seems like the lib is somewhat outdated 

    "typescript": "~2.3.2",
    "typescript-eslint-parser": "^3.0.0"

the typescript-eslint-parser (newest version is 22.0.0) is also deprecated and should be replaced with @typescript-eslint/parser

Also I get some compile errors when running with TypeScript 3 (can't extract strings anymore from most of the TypeScript files)

Would you be willing to accept a PR with TS3 support and updated eslint-parser?

rubenv commented 5 years ago

Absolutely, feel free to submit one!

Thanks for pointing this out.

ngehlert commented 5 years ago

fixed with release v2.3.15