search

rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 129 forks source link

fix: update jshint exception switch to current jshint version #79

Open clue42 opened 9 years ago

clue42 commented 9 years ago

update the jshint exception switch to current (2.6.0) version for mixed quotation marks. As of jshint > 1.0 this exception is W110 instead of the used W100

rubenv commented 9 years ago

How was this working before?

clue42 commented 9 years ago

Jshint was throwing warnings and if you do have quite a few translations, linting your source got pretty annoying.

rubenv commented 9 years ago

Ah yes. Well, I stand by my point that you should ignore generated files from linting.

This might happen again and it's totally pointless. Just don't lint machine-generated stuff, it's a waste of time.

clue42 commented 9 years ago

Well, I stumbled across this as where were some exception switches in the code, however just old ones.

gabegorelick commented 9 years ago

If we already add a JSHint directive to the generated JS, I suppose we should at least use the right directive :-)

But honestly, I would vote for not outputting any JSHint directives. Or maybe jshint:ignore

tylkomat commented 8 years ago

completely disabling jshint on the compiled file is the right choice, as one does not have influence on the global jshint settings of the developer and also one can't influence the generated code.