rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 131 forks source link

Extraction problem in table data attributes #81

Open adarshk7 opened 9 years ago

adarshk7 commented 9 years ago
<td data-title="'Name'|translate">{{ user.name }}</td>
<td data-title="'Age'|translate">{{ user.age }}</td>
<td data-title="'Job'|translate">{{ user.job }}</td>

This only extracts "Name" and "Job" (every alternate). If I use {{ }} around the string with the translate filter, then it works, but this breaks in the browser with an angular(or perhaps ngTable) error.

gabegorelick commented 9 years ago

The "no-delimiter" extraction is more complicated and less tested, so this doesn't surprise me. Looks like we don't test having more than one non-delimited string in a file: https://github.com/rubenv/angular-gettext-tools/blob/master/test/fixtures/no_delimiter.html

For now, you may want to put your strings in your JS (using the gettext service) until this is resolved.

adarshk7 commented 9 years ago

That's what I've gone with. It feels a bit ugly though to have to put those strings to the JS, but at least it works for now. Though complex, I hope this gets implemented.

Niek commented 8 years ago

We are experiencing the same issue. If anyone knows a workaround, please mention it in this issue.