search

rubenv / angular-gettext-tools

Tools for extracting/compiling angular-gettext strings.
http://angular-gettext.rocketeer.be/
MIT License
39 stars 129 forks source link

Fix #84: Replace esprima with espree for ES6 support #87

Closed smehrbrodt closed 9 years ago

rubenv commented 9 years ago

Could you also add a test case with an ES6 file that didn't work previously?

smehrbrodt commented 9 years ago

Is that test ok or do you need more tests?

rubenv commented 9 years ago

Nope, looks great.

@gabegorelick Are you cool with merging this? I'm guessing a switch to espree won't impact the gulp plugin.

gabegorelick commented 9 years ago

I would bump the major version just to be safe. It's a pretty big change and adds a significant amount of functionality (the ability to work with es6 code).

On Friday, April 10, 2015, Ruben Vermeersch notifications@github.com wrote:

Nope, looks great.

@gabegorelick https://github.com/gabegorelick Are you cool with merging this? I'm guessing a switch to espree won't impact the gulp plugin.

— Reply to this email directly or view it on GitHub https://github.com/rubenv/angular-gettext-tools/pull/87#issuecomment-91545714 .

rubenv commented 9 years ago

@gabegorelick Major as in 3.0? Or rather 2.1.0?

gabegorelick commented 9 years ago

3.0. It should be an opt in process for existing users to get es6 parsing. Although I'm probably being pessimistic in terms of what could break.

On Friday, April 10, 2015, Ruben Vermeersch notifications@github.com wrote:

@gabegorelick https://github.com/gabegorelick Major as in 3.0? Or rather 2.1.0?

— Reply to this email directly or view it on GitHub https://github.com/rubenv/angular-gettext-tools/pull/87#issuecomment-91556926 .

rubenv commented 9 years ago

@gabegorelick 3.0 is a bit of a big bump for something that should be completely compatible, no?

gabegorelick commented 9 years ago

Yeah maybe you're right.

On Friday, April 17, 2015, Ruben Vermeersch notifications@github.com wrote:

@gabegorelick https://github.com/gabegorelick 3.0 is a bit of a big bump for something that should be completely compatible, no?

— Reply to this email directly or view it on GitHub https://github.com/rubenv/angular-gettext-tools/pull/87#issuecomment-93980824 .

rubenv commented 9 years ago

Tagged as "v2.1.0".

I'll be releasing an update grunt-angular-gettext in a minute.

@smehrbrodt Thanks a lot!