Do you plan to support angular 1.3?

[tike]

Hi Ruben,

I just wanted to pull angular-gettext into my project (using angular 1.3) and was informed, that angular 1.3 is not currently supported. I would really like to use angular-gettext on my current project. I'd therefore like to know: Have you thought about porting it? Is there probably a shedule (of any kind)?

Thanks you for answering.

Timo

[rubenv]

I don't think porting will be needed. I just haven't tested it. Give it a go and let me know if things break, I'll happily help out to fix things.

[tike]

Thanks, I'll look into it and keep you posted.

[tike]

Hi, I've run the tests after switching "angular": "~1.3.0" and "angular-mocks": "~1.3.0", respectively. Running the unit tests was successfull, however the end 2 end tests threw some errors. I'd greatly appriciate any feedback on how to resolve these issues.

I've forked your repository and pushed the small change to the angular-1.3 branch https://github.com/tike/angular-gettext/tree/angular-1.3

Thank you very much for looking into this!

Cheers,

tike

Here is the complete output from running grunt karma:

Running "karma:unit" (karma) task Running "karma:unit_nojquery" (karma) task Running "karma:unitci" (karma) task INFO [karma]: Karma v0.12.22 server started at http://localhost:9877/ INFO [launcher]: Starting browser Firefox INFO [launcher]: Starting browser PhantomJS INFO [PhantomJS 1.9.7 (Windows 7)]: Connected on socket 6g70akqes4cKzCMbQbSN with id 32921817 ....................................................... PhantomJS 1.9.7 (Windows 7): Executed 55 of 55 SUCCESS (0.26 secs / 0.089 secs) INFO [Firefox 31.0.0 (Windows 7)]: Connected on socket fNVcXks7DXptOiG4QbSO with id 806016 ....................................................... Firefox 31.0.0 (Windows 7): Executed 55 of 55 SUCCESS (0.27 secs / 0.085 secs) TOTAL: 110 SUCCESS

Running "karma:unitci_nojquery" (karma) task WARN [karma]: Port 9876 in use INFO [karma]: Karma v0.12.22 server started at http://localhost:9877/ INFO [launcher]: Starting browser Firefox INFO [launcher]: Starting browser PhantomJS INFO [PhantomJS 1.9.7 (Windows 7)]: Connected on socket eoHrY1FuBUjEPYoLQcmo with id 7093663 ....................................................... PhantomJS 1.9.7 (Windows 7): Executed 55 of 55 SUCCESS (0.15 secs / 0.051 secs) INFO [Firefox 31.0.0 (Windows 7)]: Connected on socket e2EO4k5NJTapLfksQcmp with id 74951042 ....................................................... Firefox 31.0.0 (Windows 7): Executed 55 of 55 SUCCESS (0.25 secs / 0.066 secs) TOTAL: 110 SUCCESS

Running "karma:e2e" (karma) task Running "karma:e2eci" (karma) task WARN [karma]: Port 9876 in use INFO [karma]: Karma v0.12.22 server started at http://localhost:9877/karma/ INFO [launcher]: Starting browser Firefox INFO [launcher]: Starting browser PhantomJS INFO [PhantomJS 1.9.7 (Windows 7)]: Connected on socket MieBvycuA7DdtyYcQdY5 with id 5772633 WARN [proxy]: failed to proxy /test/fixtures/click.html (connect ECONNREFUSED) INFO [Firefox 31.0.0 (Windows 7)]: Connected on socket hbnHYXAn2SbUJrLrQdY6 with id 34577403 WARN [proxy]: failed to proxy /test/fixtures/click.html (connect ECONNREFUSED) WARN [PhantomJS 1.9.7 (Windows 7)]: Disconnected (1 times), because no message in 10000 ms. PhantomJS 1.9.7 (Windows 7): Executed 0 of 8 DISCONNECTED (10.015 secs / 0 secs) WARN [Firefox 31.0.0 (Windows 7)]: Disconnected (1 times), because no message in 10000 ms. Firefox 31.0.0 (Windows 7): Executed 0 of 8 DISCONNECTED (10.003 secs / 0 secs) Warning: Task "karma:e2eci" failed. Use --force to continue.

Aborted due to warnings.

[rubenv]

Looks like Karma fails completely on the E2E tests. One possible cause is that the E2E tests still use the (deprecated) ng-scenario framework. We should probably update them to use Protractor.

Here's a project that does use Protractor for E2E testing: https://github.com/rubenv/angular-import-scope

[tike]

read your article about unit testing on savanne.be, very good material. Thanks for preparing and sharing it.

I'll try to get the referenced project up and working (as a test bed for the protractor/selenium stuff) and then we'll see where we go from there.

[rubenv]

Cool, good luck!

Glad you enjoyed the article :-)

On Mon, Aug 25, 2014 at 3:39 PM, tike notifications@github.com wrote:

read your article about unit testing on savanne.be, very good material. Thanks for preparing and sharing it.

I'll try to get the referenced project up and working (as a test bed for the protractor/selenium stuff) and then we'll see where we go from there.

— Reply to this email directly or view it on GitHub https://github.com/rubenv/angular-gettext/issues/96#issuecomment-53264442 .

[tike]

Hi Ruben,

sorry it took me such a long time to get back to you. However, the tests actually run flawlessly! As far as I can tell :-)

I think the problem with the failing tests above was rather, that invoking grunt karma does not launch the connect:e2e task. When I ran grunt connect:e2e karma everything worked perfectly.

I don't know wether this behaviour is intentional or not, anyway it would be a separate issue.

Thanks again for looking into this and for the awesome package.

cheers

tike

[rubenv]

We recently released a fix for the upcoming 1.3, so be sure to use at least v 1.1.1 (latest right now is 1.1.2).

Enjoy!

[tike]

Just checked with v1.1.2, all tests passing with angular#1.3.0-rc.2

[hcentelles]

Any plans to support One-time bindings or a similar approach for translated text?

[intellix]

@hcentelles related: https://github.com/rubenv/angular-gettext/issues/80

[rubenv]

One-time bindings should be supported, unless I'm mistaken. I don't think there's something special we need to do here.