search

rubenv / grunt-git

Git commands for grunt.
MIT License
227 stars 83 forks source link

Adding overwrite functionality to Git Clone command #46

Closed ajmichels closed 10 years ago

ajmichels commented 10 years ago

If the destination directory already exists and the overwrite option is set to true the directory will be removed then the clone will proceed.

rubenv commented 10 years ago

This pull request poses an interesting problem. There are a number of problems with where grunt-git currently deviates from git behavior. There's a plan to fix that and map 1:1 with git in future versions (see #44).

An overwrite option brings us further away from that. So what should we do with that?

What problem are you trying to solve here? Could you elaborate a bit on it?

And couldn't this be solved with a combination of clean and checkout as it currently is?

ajmichels commented 10 years ago

Ah. Well if that is your goal, to keep this a 1:1 implementation of Git then you can ignore this pull request.

Yes. This could be accomplished by using clean but I like keeping my configuration simple.