search

rubenv / node-apk-parser

Extract Android Manifest info from an APK file.
MIT License
80 stars 25 forks source link

fix the bug that apk parser don't parse manifest when the apk using A… #13

Closed yky3489 closed 7 years ago

yky3489 commented 7 years ago

…ndroid SDK v24 compiled.

rubenv commented 7 years ago

Hi, looks like the tests don't work, could you look into this?

yky3489 commented 7 years ago

Hi Ruben: I changed test_v24.js because the test_v24.apk have the different packagename and platformBuildVersionCode.

rubenv commented 7 years ago

Hey, thanks a lot!

I also added one extra test case: https://github.com/rubenv/node-apk-parser/commit/70c5b5c6f2e86ccef954b7b70df9d8edb5c25ab1

Without this, there's no verification that the new code actually does the right thing. With this extra test case in place we're sure that it works and, more importantly, that it will keep working in the future.

I've released v0.1.7 to NPM with this fix.