search

rubenv / node-apk-parser

Extract Android Manifest info from an APK file.
MIT License
79 stars 25 forks source link

Buffer should be bigger #3

Closed gergelyke closed 9 years ago

gergelyke commented 10 years ago

1024*1024 is not always enough. It would be nice to have an option what can be passed in, or just simple make it larger.

msalahat commented 9 years ago

I have created a pull request here with patch that has maxBuffer as configuration option that you can specify when calling the parser https://github.com/rubenv/node-apk-parser/pull/5 Once approved you can call the parse as below parseApk(FILE_PATH , MAX_BUFFER ,CALLBACK ); Or you can use my fork here https://github.com/msalahat/node-apk-parser/

gergelyke commented 9 years ago

Thanks @msalahat ! In the meantime I forked as well :)

https://github.com/gergelyke/node-apk-parser2

rubenv commented 9 years ago

@gergelyke please send fixes back as pull requests

rubenv commented 9 years ago

Published version 0.1.1 to npm

gergelyke commented 9 years ago

Will do - I thought the repo is dead, as I got no response

rubenv commented 9 years ago

Might have missed that mail. I think I was on a vacation then. Never hurts to ping a second time.

Do note that I don't blindly implement every feature request (I'm not getting paid for that), but I happily review pull requests.

rubenv commented 9 years ago

Anyway, thanks a lot for the patch @msalahat!

gergelyke commented 9 years ago

No worries, I only needed that for a prototype - also, I am putting a deprecation notice on the fork, pointing it to here.

msalahat commented 9 years ago

@rubenv You are welcome :)