search

rubenv / sql-migrate

SQL schema migration tool for Go.
MIT License
3.23k stars 280 forks source link

Readme has inconsistent naming of config files #107

Closed neoneye closed 5 years ago

neoneye commented 6 years ago

The current readme is using both dbconfig.yml and config.yml.

This makes the user unsure about what is best practice naming the config file.

rubenv commented 6 years ago

No really strong opinions on this (whatever works is fine), though dbconfig is probably better as the file on refers to database configuration.

Would you mind submitting a PR?

On Sat, Mar 31, 2018, 11:07 Simon Strandgaard notifications@github.com wrote:

The current readme is uses both dbconfig.yml and config.yml.

This makes the user unsure about what is best practice naming the config file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rubenv/sql-migrate/issues/107, or mute the thread https://github.com/notifications/unsubscribe-auth/AACnmPe6G9ab65JrrgbP6ycSzsbreQUUks5tj0dogaJpZM4TCZNk .

opensas commented 5 years ago

here's a PR