Open quintenpalmer opened 5 years ago
@rubenv have you had a chance to take a look at this PR? Would like to get this merged to you upstream if possible, let me know if that will be the case please.
@rubenv I have added env configurability to the ignore-unknown setting as well. If you are interested in env configurability, it would be great if this PR could get merged first so that I can open a PR for the ignore-unknown addition.
Our company has a use case to provide the environment information through the shell environment instead of from a
dbconfig.yml
file. We have augmented thesql-migrate
binary's capability to check for adbconfig.yml
file before trying to read it in, and if there is no file present, it will be optimistic and try to read from the shell environment. Failing to read from the environment if there is no file will work as it did before with the zero-value checking that happens in the last part ofGetEnvironment
. If these changes are acceptable to introduce to the parent project would like to do so.Example usage showing that this:
dbconfig.yml
if presentdbconfig.yml
is not present