Support native golang embed.FS

rubenv / sql-migrate

SQL schema migration tool for Go.

MIT License

3.18k stars 270 forks source link

Closed insidieux closed 3 years ago

insidieux commented 3 years ago

Is your feature request related to a problem? Please describe.

Since version 1.16 golang support native embedding with packages embed and io/fs.

Describe the solution you'd like

Update minimal golang required version to 1.16 and provide MigrationSource with support embed.FS. I'll provide pull request a little bit later.

rubenv commented 3 years ago

Also see the related #189

insidieux commented 3 years ago

Also see the related #189

Ok, i've watched issue and pull.

I have some questions:

Do we really need support of old golang version?
I'd prefer to provide new MigrationSource implementation, instead of changing behaviour of previous existed. Is it ok for you?

rubenv commented 3 years ago

Is there a reason why we need to break compatibility with older Go versions?

insidieux commented 3 years ago

Is there a reason why we need to break compatibility with older Go versions?

No, there is no suitable reasons. I've just ask your opinion.

Would you prefer: to make me commits, comments to previous pull or send newest?

rubenv commented 3 years ago

No, there is no suitable reasons. I've just ask your opinion.

Then let's not do that. We never break compatibility if we can avoid it.

Would you prefer: to make me commits, comments to previous pull or send newest?

Let's work together on the other PR.

insidieux commented 3 years ago

Ok, thanks, now i'm closing this issue and provide some comments to related.