search

rubenv / sql-migrate

SQL schema migration tool for Go.
MIT License
3.18k stars 270 forks source link

Update gorp dependency to gorp.v2 #205

Open jamesatwill-okta opened 2 years ago

jamesatwill-okta commented 2 years ago

Hi! Could I convince you to migrate from gorp.v1 to gorp.v2?

There's only one note in the migration guide: https://github.com/go-gorp/gorp#pre-v2-to-v2

rubenv commented 2 years ago

It's probably about time we do that indeed!

Could you send a PR?

idcmp commented 2 years ago

https://github.com/rubenv/sql-migrate/pull/206 bumps to the latest gorp which is backwards compatible with v2.2.0 except it cleans up its go.mod handling. HTH!

rubenv commented 2 years ago

Closed in #206, thanks @idcmp

wonsikin commented 2 years ago

@jamesatwill-okta @rubenv Found an issue after #206 was merged

$ go get -v github.com/rubenv/sql-migrate/...
github.com/rubenv/sql-migrate (download)
github.com/go-gorp/gorp (download)
package github.com/rubenv/sql-migrate: cannot find package "github.com/go-gorp/gorp/v3" in any of:
    /usr/local/go/src/github.com/go-gorp/gorp/v3 (from $GOROOT)
    /go/src/github.com/go-gorp/gorp/v3 (from $GOPATH)
slee500 commented 2 years ago

@wonsikin Had the same error too. If you do export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/... this fixes the issue.

joj0hq commented 2 years ago

@slee500 @wonsikin I did export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/.... But I had same error too. My Golang version is 1.15.0.

joj0hq commented 2 years ago

I'm sorry. I had mistake. If you do export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/... this fixes the issue. But I don't know this reason.

slee500 commented 2 years ago

@jotaro-biz here's a good writeup on what export GO111MODULE=on does. https://maelvls.dev/go111module-everywhere/