search

rubenv / sql-migrate

SQL schema migration tool for Go.
MIT License
3.24k stars 280 forks source link

Fix: getMigrationDbMap method incorrectly uses the global migration set #236

Closed charithe closed 1 year ago

charithe commented 1 year ago

Setting DisableTableCreate on a MigrationSet has no effect because the getMigrationDbMap method on MigrationSet uses the global migSet instead of the instance variable.

Signed-off-by: Charith Ellawala charith.ellawala@gmail.com

peterldowns commented 1 year ago

@charithe I just noticed that you had written this PR, I also wrote a PR to fix the same problem #242 . Hopefully one or both of these can get merged.

rubenv commented 1 year ago

242 fixed this