Closed peterldowns closed 1 year ago
You can see an example run of the proposed workflows here, on this PR (same branch, just opened as a PR against my fork so that the workflow has permissions to run) https://github.com/peterldowns/sql-migrate/pull/1
https://github.com/peterldowns/sql-migrate/actions/runs/5136897251
Oh thank you very much!
Once Travis died I never got round to properly adding CI again. This is great.
@rubenv you're welcome, I'm happy that I was able to contribute something useful :) If you run into any problems with it, please just tag me or send me an email and I can try to help out.
While I was working on https://github.com/rubenv/sql-migrate/pull/242 I was surprised to find a lack of automated testing. If you'd like, this PR sets up CI on Github Actions and adds some linting rules, too. I think switching to Github Actions will make it easier for people to contribute and make sure they're not breaking anything, especially for older versions of golang. Hopefully it will make your life easier as a maintainer, too.
If you are not interested, no problem, please feel free to close the PR.
make lint
,make test
, andmake build
go build
andgo test
for golang version 1.13-1.20golangci-lint
andgo mod tidy
and makes sure there were not any changes detectedgolang.org/x/sys
, which as of recent versions usesunsafe.Slice
which was introduced with go1.17.