Fix version check to compare minor version

rubenv / zipper

Insanely simple zipfile creator for node.js.

http://savanne.be/445-zipper-an-insanely-simple-zipfile-creator-for-node-js

Other

33 stars 6 forks source link

Fix version check to compare minor version #11

Open dohse opened 9 years ago

dohse commented 9 years ago

Bugfix versions should be compatible with each other. Compare only the major and minor version of node.

rubenv commented 9 years ago

They're API compatible, but are they ABI compatible?

dohse commented 9 years ago

Unfortunately I am not able to find any statements about this. The original version of this check forces us to upgrade node on all our machines in concert which would be a hassle. We are using several other binary modules which never caused us any trouble, so it looks like that in practice different bugfix versions of node are ABI compatible.