search

rubenvanassche / Programming-Project-Databases

A World championship statistics website
coachcenter.be
GNU General Public License v3.0
1 stars 1 forks source link

Penalty phase goals #82

Closed JakobStruye closed 10 years ago

JakobStruye commented 10 years ago

@Stijn-Flipper I noticed the penalty phase field is NULL for goals. Does this mean the crawler makes no distinction between regular goals and penalty phase goals or that penalty phase goals are not crawled?

Maybe it would be best to just not have penalty-phase goals in our db. You can't bet on them, and we would have to modify a bunch of queries if we suddenly added them. We'd also have to add something to the Match page to show them. You can't bet on who is going to win a match, nor does the Match page indicate a winner for played matches. This means we don't really need penalty phase goals for anything we have already implemented. Does anyone disagree?

STOWouters commented 10 years ago

yes, I aggree, the crawler cannot make any distinction between penalty and an ordinary goal at all. It's too difficult to make such distinction.

JakobStruye commented 10 years ago

So, are penalty goals skipped now?

STOWouters commented 10 years ago

no, they are counted as a goal.

JakobStruye commented 10 years ago

Do you know of any specific match where this happens?

STOWouters commented 10 years ago

France - Mexico

JakobStruye commented 10 years ago

I don't mean the penalties during the regular 90 minutes, I mean the part where the score is tied, but there has to be a winner, so both teams get 5 penalties.

STOWouters commented 10 years ago

Ain't nobody got time fo' dat

JakobStruye commented 10 years ago

I just wanna make sure they're not counted as goals, so that those matches don't end up with 8-7 or scores like that.

STOWouters commented 10 years ago

so is this issue closed?

JakobStruye commented 10 years ago

Brazil - Italy This specific match seems to be missing from our db, but would this result in a 0-0 or 3-2?

Edit: as seen here, penalty shootout goals are not in the same section as regular goals. I assume goals are crawled from the Goals section? If so, it can be closed. Mexico - Bulgaria

STOWouters commented 10 years ago

Brazil - Italy, Mexico - Bulgaria This specific match seems to be missing from our db, but would this result in a 0-0 or 3-2?

First one should result in 0-0, last one is 1-1, but I see those matches comes from the final stages, in the previous version of the crawler, it only inserted matches from the group stages. However, I'm currently running the crawler to get all matches. This might take a while.

I assume goals are crawled from the Goals section?

No, the goals, same with the cards are crawled from lineups and substitutes section. This to avoid really smelly hacks.

STOWouters commented 10 years ago

Reopened, since I've forgotten to drop the penaltyphase field in goal table. I'll fix that soon.