search

rubenvereecken / pokemongo-api

Pokemon Go API for Python
Other
358 stars 120 forks source link

Nice codebase #1

Closed p0psicles closed 8 years ago

p0psicles commented 8 years ago

Will be watching this! Like your OO approach. Your accepting PR's? On IRC?

rubenvereecken commented 8 years ago

I should get a communication channel, not sure where though. Might go on Slack/Gitter.

Don't have incredible amounts of time to spend on this though. Investigating the proto's that go over the wire is slow-going especially, so I'll probably look out what others can make of it and incorporate into this API. So yes, definitely accepting PRs.

dmadisetti commented 8 years ago

@rubenvereecken Slack channel https://pkre.slack.com/messages/reversing/ and invite https://shielded-earth-81203.herokuapp.com/ and a more organized proto repo https://github.com/AeonLucid/POGOProtos

rubenvereecken commented 8 years ago

Looks like I'll visit that channel then. Drop me a line there @p0psicles whenever you want.

m3talstorm commented 8 years ago

Please follow standard Python naming conventions and format.

rubenvereecken commented 8 years ago

@m3talstorm this started out as a Py 3.5 project but I switched because the generated code was crap. But you're right, it's an issue.