Message Changes - Githubissues

rubenvereecken / pokemongo-api

Pokemon Go API for Python

Other

358 stars 120 forks source link

Message Changes #72

Closed hilburn closed 8 years ago

hilburn commented 8 years ago

Messages:

Adds LevelUp message (allows to check for level up and claim rewards)
Adds XpBoost message (allows use of a lucky egg - will fail if you use it while it's already active)
Adds a multi-evolve/release message that massively reduces packets sent when mass evolving or releasing pokemon. Retains the single pokemon functions

Pokedex:

adds a dictionary which will map any given pokemon to it's candy type (also good for finding evolution trees) which I found useful

hilburn commented 8 years ago

Just noticed a bunch of changes in session I missed - going to fix it quickly

dmadisetti commented 8 years ago

Hmmm. I'm not sure I like your mass requests. It's not possible from the client

hilburn commented 8 years ago

Not possible currently, but given that the API supports it currently, and how frequently the functionality is asked for in the client, it's likely to be included in future versions. Adding it in just gives people a few more options about how to interact with the API, if they want to play it safe and stick to client-valid messages then they can use the single-shot requests. If you wanted to restrict the codebase to only client-like behaviour the sleeps after eg evolve/capture would be much longer to account for the unskippable animations.

dmadisetti commented 8 years ago

That's true. I reverted it for now, but would be open to including it later. If we go down that route, I might be open to have a "build your own request" kind of functionality where you can easily string a ton of requests together