search

rubenvereecken / pokemongo-api

Pokemon Go API for Python
Other
358 stars 120 forks source link

Modified to Trainer.cleanPokemon() to be more selective #95

Closed jmaygarden closed 8 years ago

jmaygarden commented 8 years ago

This changes cleanPokemon to accomplish the following:

  1. Always keep one strongest pokemon of each type even if it is below the CP threshold. This prevents collectors from losing a pokemon type from their party just because it is weak.
  2. Release the weakest pokemen for candies before evolving so that stronger pokemon are evolved.
  3. Keep evolved pokemon for the next sweep in case any are stronger than others in the party.
dmadisetti commented 8 years ago

Hmm. This is function can go a variety of ways. I run into out of space regularly, and the existing function works very well for me. I'm going to recommend extending trainer and implementing more detailed logic there.

I'm reluctant to merge this since there isn't a right answer

jmaygarden commented 8 years ago

That's understandable. I'm finding that I'd like more flexibility here as well.