Updated version of soap module to current

rubicon-project / node-google-dfp

A service for integrating with Google DFP over NodeJS

ISC License

85 stars 34 forks source link

Closed tandrus closed 9 years ago

tandrus commented 9 years ago

Updated version of soap module, because with version 0.5.0 module google-node-dfp didn't work.

tandrus commented 9 years ago

@ajsouza I found one critical bug in soap version 0.9.0. WSDL file are build with incorrect tags ns1:ns1:tag

Today I will try to fix it and create pull request for soap library and after fixing this bug please change version of soap library.

ajsouza commented 9 years ago

@tandrus I updated the git repo to avoid the double tags -did you pull?

tandrus commented 9 years ago

@ajsouza Sorry, I didn't do it. After pulling repo - duplicate tags disappear.

ajsouza commented 9 years ago

Thanks, I was hoping to confirm that updating SOAP lib wouldn't break for some versions of node (specifically 12). I will publish to NPM.