search

rubiconmd / injectable

Opinionated and declarative Dependency Injection library for ruby.
https://rubygems.org/gems/injectable
MIT License
34 stars 5 forks source link

Introduce Ruby Actions for CI #14

Closed julitrows closed 4 years ago

julitrows commented 4 years ago

Issue #9

I used one of the starter actions available in GH Actions to set up the gem and run the specs.

Check out the successful checks section to see that it works

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 788b2a76 and detected 0 issues on this pull request.

View more on Code Climate.

iovis commented 4 years ago

This is awesome! Could we make it so it runs the specs on the PR as well?

julitrows commented 4 years ago

Let me look into it

julitrows commented 4 years ago

By looking at the docs and the trace I'd say it works by default on PRs that target master

Captura de pantalla 2020-03-16 a las 13 40 04 Captura de pantalla 2020-03-16 a las 13 39 23

It would be weird if it ran the specs against the master branch when opening a PR against it, instead that on the branch that makes the changes

iovis commented 4 years ago

To be honest, if it didn't work like that probably this action wouldn't have run till we merged to master. I need more coffee.