search

rubiconmd / injectable

Opinionated and declarative Dependency Injection library for ruby.
https://rubygems.org/gems/injectable
MIT License
34 stars 5 forks source link

Add Ruby 3 versions to build matrix #29

Closed bertocq closed 2 years ago

bertocq commented 2 years ago

Context

Casually browsing the public repos of RubiconMD, as a newly hired employee.

@aalbagarcia told me main apps currently use latest Ruby versions, so it makes sense to also add them to the build matrix for this gem.

Not removing old EOL ruby versions as there might be still usages of the gem in repos that are not so up-to-date with Ruby

Details

Check https://www.ruby-lang.org/en/downloads/branches

bertocq commented 2 years ago

I wonder if this repo could benefit from executing tests as part of the CI workflow.

I was expecting errors for Ruby 3.1.2 (as tests fail on my local machine for that version, but not for others). Screenshot 2022-10-10 at 16 39 22

I've never used Github actions as CI/CD so I might be missing something.

bertocq commented 2 years ago

Ah! This appeared just now :)

Screenshot 2022-10-10 at 16 41 20

Maybe that's where tests would be executed, and somehow github trolled me not showing it before my previous comment 🤔

aalbagarcia commented 2 years ago

Hey @bertocq I've just unlocked the Checks in circle CI/CD

aalbagarcia commented 2 years ago

@bertocq There are some issues with ruby 3.2 (not sure if you can see the actions tab in the top menu and/or can see the results of the checks)

bertocq commented 2 years ago

@bertocq There are some issues with ruby 3.2 (not sure if you can see the actions tab in the top menu and/or can see the results of the checks)

Yes I saw CI couldn't find 3.2.x, so I've removed it from the list

3.2.x it's on preview status anyway so it was a bit overkill to include it already

bertocq commented 2 years ago

Okey now the CI was able to run tests with success with all ruby versions but 3.1.x:

Screenshot 2022-10-11 at 10 42 55

iovis commented 2 years ago

Hi @bertocq! Thank you for your contribution, let's bring this one home:

Ruby 2.5 and 2.5 are at End Of Life status

You can remove them, let's start with 2.7

Ruby 3.1.X fails

Seems related to this issue: https://github.com/rspec/rspec-expectations/issues/1338

You can bundle update rspec, I tested with the latest version and it seemed to work again with ruby 3.1.X

bertocq commented 2 years ago

Hi @bertocq! Thank you for your contribution, let's bring this one home:

Thanks! I was just "probing" how relevant/important this repo is :), to see if it's worth the time investment. Also without access to private repos that was all I could contribute 😅 .

Ruby 2.5 and 2.5 are at End Of Life status You can remove them, let's start with 2.7

Done with https://github.com/rubiconmd/injectable/pull/29/commits/ae0af4fc78d7dd1ed70a85956e957fcd8c471098 👌

Ruby 3.1.X fails

Seems related to this issue: rspec/rspec-expectations#1338

You can bundle update rspec, I tested with the latest version and it seemed to work again with ruby 3.1.X

Nice catch! I was looking into the wrong spots 🙈 , done with https://github.com/rubiconmd/injectable/pull/29/commits/94ba976b76788cc7e64ef68be07a6da299b376ec

Also updated bundler version to match Gemfile.lock one https://github.com/rubiconmd/injectable/pull/29/commits/cc4404cfc79bb76b442a3427f77b68bd27a276e0

That last bit with rubocop's config seems out of my reach for now

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 06540949 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.