search

rubiconmd / injectable

Opinionated and declarative Dependency Injection library for ruby.
https://rubygems.org/gems/injectable
MIT License
34 stars 5 forks source link

First stab at README #6

Closed Papipo closed 5 years ago

Papipo commented 5 years ago

Pretty self explanatory.

julitrows commented 5 years ago

Also do you think having the docs we have for SO's and Injectable in GDrive could be of good use here in this repo as content in the wiki?

And I think this is a great opportunity to kickoff the RMD youtube video channel and upload your dev learning talks related to Injectable and their slides.

All material we can provide to show everyone motivation, examples, and explanations should be made public :)

Papipo commented 5 years ago

Maybe it's not really needed, but perhaps a section on "how to test your Injectable powered service objects" with some examples written in favorite library for specs would be nice.

I agree, one of the benefits of injecting dependencies is to pass stubs. Should I do that in this PR?

Also I'm wondering if we should specify the version of Ruby this was developed against (2.5.1), and that we do not guarantee that this works 100% under any other Ruby versions. I guess the minimum supported Ruby version is the version of ruby which introduced keyword arguments. Perhaps an enchancement would be having tests against a matrix of ruby versions.

Good point. I suggest @amrocco to do that if he wants :-)

Papipo commented 5 years ago

Also do you think having the docs we have for SO's and Injectable in GDrive could be of good use here in this repo as content in the wiki?

Not sure... Can we keep the memes?

And I think this is a great opportunity to kickoff the RMD youtube video channel and upload your dev learning talks related to Injectable and their slides.

Oh my 😊

julitrows commented 5 years ago

Specs -> yeah, do it on this PR Matrix -> at least include the explanation on the version used. Leave the matrix for the future. Memes -> I think memes can stay, I'm more worried about code examples if they are revealing of our codebase. Youtube thing -> ask @timlawrenz

Papipo commented 5 years ago

Specs -> yeah, do it on this PR

Working on it.

Matrix -> at least include the explanation on the version used. Leave the matrix for the future.

Done.

Memes -> I think memes can stay, I'm more worried about code examples if they are revealing of our codebase.

I think the code was made up. Something about team rosters and players? 🤣

Youtube thing -> ask @timlawrenz

I might