Add support for GHC >= 8 and dropped support for older versions

rubik / argon

Monitor cyclomatic complexity in Haskell programs

BSD 3-Clause "New" or "Revised" License

97 stars 8 forks source link

Add support for GHC >= 8 and dropped support for older versions #33

Closed dnadales closed 6 years ago

dnadales commented 6 years ago

This PR contain the following proposals:

Drop support for GHC < 8
Add support for GHC >= 8
Drop support for test coverage at the travis script (stack-hpc-coverals) not available for GHC 8.2.2.
Update the readme:
- Explanation of cyclomatic complexity
- Mention which versions of GHC are now supported
Remove the dependency on pipes-files, which is not maintained anymore. This also enables the build of argon on Windows.

Fixes #32

rubik commented 6 years ago

Wow you did an amazing job! I'm really grateful because in the last few months I have been too busy to maintain it. If you agree I would add you as a collaborator on the project so you can become the maintainer.

dnadales commented 6 years ago

On the contrary, thanks for all the work you put into developing this tool!

Feel free to add me as a collaborator, I'll try to keep argon up to date for future versions of GHC, and maybe add some more functionality. I'll always include you in the pull requests so that you can give me your blessing :)

BTW, could you add me as a collaborator on hackage as well, so I can upload the new version.

rubik commented 6 years ago

Great! Done and done. I have created a token on Hackage so you can upload packages on my behalf. I couldn't find you email address so I sent it to your LinkedIn account.

dnadales commented 6 years ago

Thanks. But maybe you can add my username (dnadales) as a co maintainer, I think that way might be easier.

rubik commented 6 years ago

Sure, done. I actually wasn't aware of this possibility.

nh2 commented 1 day ago

@dnadales Do you still intend to upload the change here to Hackage? It still has the old version.