search

rubik / stack-hpc-coveralls

Coveralls support for Stack projects
ISC License
33 stars 15 forks source link

Fix stack version check #8

Closed wayofthepie closed 8 years ago

wayofthepie commented 8 years ago

The latest stack, version 0.1.10.0, does not work with shc because of the version check (woops :P).

It checks if "0.1.7.0" <= "0.1.10.0" which is False.

This change is a more robust version check, I added a test here too, just in case!

wayofthepie commented 8 years ago

I didn't notice that makeVersion was only put into base in 4.8! Will update soon.

rubik commented 8 years ago

Ah thank you so much. This version checking keeps bothering me. And thanks for adding unit tests.

rubik commented 8 years ago

I'll release a new version.