Use pipenv to replace using pip and virtualenv separately

rubikvn / RubikVNdotOrg

Source code for https://www.rubikvietnam.org

2 stars 0 forks source link

Use pipenv to replace using pip and virtualenv separately #17

Closed trungams closed 5 years ago

trungams commented 5 years ago

Feature/Enhancement Description

This is obv a better packaging management tool

Tasklists Suggestion

[x] Try setting up pipenv on local
[x] If it works, remove requirements.txt and rbvn folder for virtualenv since pipenv will use a different folder to manage virtual environment
[ ] Update README with our changes to setting up the repo

Additional Comments

trungams commented 5 years ago

Got the first task done. My local machine was lacking python3.6-dev (maybe) and more importantly libmysqlclient-dev so pipenv install failed on my first run. It worked after I installed the two packages. Will try to check if the same issue exists in docker build.

trungams commented 5 years ago

seems good

trungams commented 5 years ago

Resolved in #18. I tagged the wrong issue in that PR commit :cry: