search

rubillos / RV-Bridge

Homekit to RV-C bridge - Allows control of RV lights, fans, and thermostats via HomeKit.
73 stars 11 forks source link

Add capability to configure Wi-Fi settings without rebuilding the code #6

Closed oilcan-productions closed 1 year ago

oilcan-productions commented 1 year ago

I have several Wi-Fi hotspots I use the adapter with. currently I modified a private build to scan for Wi-Fi and select the right access point and password from a list rather than a single AP in the config file.

I think the functionality that if the configured wifi is not found the device comes up in AP mode and I can connect to a simple page to configure wifi there and write that to the NVRAM or the config file would be great.

oilcan-productions commented 1 year ago

I am going to take a stab at this over the next 2 weeks or so and send a PR

rubillos commented 1 year ago

Great! (I'd suggest just adding an #ifdef on ssid around setWifiCredentials so if ssid is not defined then you can just use the HomeSpan serial commands to set/change the wifi setup).

mkostersitz commented 1 year ago

Thanks for the suggestion. I submitted https://github.com/rubillos/RV-Bridge/pull/8/ with the change

rubillos commented 1 year ago

Added ability to not set wifi credentials by defining SKIP_WIFI_CREDENTIALS.