search

rubin-dp0 / Support

Submit Github Issues related to DP0
MIT License
1 stars 3 forks source link

[BUG] Column constraints in RSP TAP #26

Closed igorandreoni closed 2 years ago

igorandreoni commented 2 years ago

In the RSP TAP online service, the table constraints inserted manually get applied to the wrong column, at least in the case of "cModel" columns.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'RSP TAP Search'
  2. Insert coordinates (e.g. "61.863 -35.79")
  3. Insert column constraint (bottom right, e.g. mag_z_cModel < 20, see screenshot 1)
  4. See the query results, or the ADQL query by clicking "Populate and edit ADQL"
  5. The constraints are applied to the wrong column (see screenshot 2)6.

Note that this problem does not occur, for example, for columns including "ra", "mag_i", "mag_z".

Expected behavior I would expect that, if I set a constraint on the column mag_z_cModel, this results in a WHERE condition (and query results) that concern the column of interest.

Screenshots Constraint that I set

Screen Shot 2022-04-14 at 9 15 10 AM

Resulting ADQL query

Screen Shot 2022-04-14 at 9 15 22 AM

URL https://data.lsst.cloud/portal/app/?__action=layout.showDropDown&

frossie commented 2 years ago

Thanks for the report, we're looking into it.

frossie commented 2 years ago

Good job all around - (1) you have found a bug and (2) we have apparently already fixed it in the codebase. It should get deployed next week, and I'll leave the ticket open till that happens.

igorandreoni commented 2 years ago

This is great to hear, thank you Frossie!

frossie commented 2 years ago

I can confirm that the upcoming portal release does fix this issue (see screenshot from our integration environment). It's a big release and folks would like more testing time, but I am inclined to take the calculated risk and push it out this Patch Thursday. Will update.

PS. Thank you for an excellent bug report, made it very easy to reproduce.

Screenshot of Safari (2022-04-19, 20-17-06)
frossie commented 2 years ago

Sadly we were not able to clear testing in time for this week's Patch Thursday (it's a big update) - so this will be out in production next week.

igorandreoni commented 2 years ago

Thanks for the update, Frossie. There is no urgency on my end. Looking forward to the big deployment!

frossie commented 2 years ago

I am sorry forgot to update and mention we deployed last week! Try it now :-)

igorandreoni commented 2 years ago

It seems to work nicely now. Thanks again!