Closed JoanneBogart closed 2 years ago
I would add the "Documentation" label but I don't see a way to do it.
Thank you very much for your careful copyediting, @JoanneBogart .
All changes except the following have been made (branch tickets/PREOPS-586, https://jira.lsstcorp.org/browse/PREOPS-586).
3.2 first code cell: variable “hover_tool” isn’t used --> MLG this is necessary to define, did not delete
3.3 Third code cell. This doesn’t appear to be used for anything --> MLG this is adding the hover tool and defining other tools, as noted in the comments
3.4 Second code cell: variable “hover_tool” isn’t used --> MLG this is necessary to define, did not delete
Changes pushed to main and prod. All done!
I still don't see that those particular hover tools I mentioned are needed. For the first item I mentioned, I commented out the line defining hover_tool and everything worked just fine. That variable is not used below. Instead, in the next cell there is
p.add_tools(HoverTool(tooltips=tooltips))
That's the code that defines and adds the hover tool.
The code under 3.4 is similar: The variable hover_tool
is defined but not actually used.
For 3.3, if I leave the code as is. the information displayed when hovering comes from
hover = HoverTool(tooltips=[("(RA,DEC)", "(@ra, @dec)"),
("(g-r,g)", "(@gmr, @gmag)"),
("objectId", "@objectId"),
("type", "@truth_type")])
only. The code defining hover_tool
in the cell above has no effect that I can see.
Note similar comment in: https://github.com/rubin-dp0/tutorial-notebooks/issues/23
Describe the bug There are some typos and a couple instances of unused code.
To Reproduce Read through the notebook
Expected behavior Here are a list of suggested changes:
URL N/A
Desktop (please complete the following information):
Smartphone (please complete the following information): N/A
Additional context Add any other context about the problem here.