Closed jeffcarlin closed 1 year ago
Units (?) warning. I think we're supposed to add a note in the tutorial if there's a non-catastrophic warning to be expected:
In this case I think it'll go away in the final version of DP0.3. They're supposed to be fixing all the units.
Thanks for the helpful review, Aaron! I think I've addressed all the comments in the version that I just pushed. Let me know if you spot anything I missed.
Thanks, will take a look at it very soon!
I see outer main belt threshold values of 4.2 AU and 4.3 AU now in the notebook, but not in the Malhotra paper's text? Where do these values come from? The Malhotra paper says a < 3.8 AU.
Also, regarding:
2.2 Main Belt asteroids -- Objects outside Mars's orbit (a > 1.6 AU)
The "a > 1.6 AU" should be "q > 1.6 AU" here.
I'm going to ask Pedro what he recommends quoting for the outer edge of the main belt before going any further -- there doesn't appear to be uniform consensus in outer thresholds adopted.
@jeffcarlin would it be possible to add an explicit statement of what the color map is/means in plots like the one shown below? My impression is that the color map is density of objects, but that would be good to mention, especially since I don't believe the literature plots like parker2008_orbit_families_sini_vs_a.png are colored by object density.
Aside from this request, there are a number of very minor edits that I can make myself via commits on this branch later today. Thanks...